Win32 input mode: fixed some bugs found while testing on real Windows Terminal #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enceParser::ParseEscapeSequence. Fixed them. In particular, 1. input buffer can contain more than one esc seq 2. respect buffer size (l variable) 3. win32 input seq length can be more than 8 bytes 4. do not mess win32 input with mouse coords events
|
There re still problems with such approach as it doesnt check sequence to be valid and can accept (and consome as whole) as winterm any multiple sequences that starts by [ and has _ inside. |
|
The man who suffered from problems in WinTerm tested it, b5f7ba3 works just as well as the one I suggested. So closing, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular,
Original bug report:
https://t.me/far2l_ru/6587
See also:
microsoft/terminal#15083