refactor(#9): move gitlab logic to specific repository package #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first step to adding github is to isolate gitlab. This PR replaces all uses of
https://pkg.go.dev/github.com/xanzy/go-gitlab#section-readme
with generic types in ourrepo
package, so they can be used regardless of the type of repository host.gitlab
package torepo
repo.go
file in which we have the common service interface & structs (Project, Issue)gitlab.go
to implement the common interfaceWith this change to add github I expect we will need to:
repo/github.go
service which implements the common interfacepatrol
to provide a different repository service based on the path type (gitlab vs github)