You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
pyfiglet version in elementary has a hidden dependency on setuptools on some versions of python (I believe > 3.11) that causes edr cli to fail with the following error message
ModuleNotFoundError: Nomodulenamed'pkg_resources'
This looks like it relates to this issue on pyfiglet repo here that has been fixed pwaller/pyfiglet#124
To Reproduce
Steps to reproduce the behavior:
(1) Clone repo
git clone https://github.com/elementary-data/elementary.git
cd elementary
(2) Create then activate a virtual environment using a python version above 3.11, for example using pyenv you could do the following
To add on top of the issue, actually usage of pkg_resources implicitly assume that setuptools are present in the environment (no explicit dependency currently stated). While it's not the case if, for example, uv is used to initiate the venv instead of pip.
Merged the fix, thanks for contributing @jcarpenter12 !
thank you @haritamar , do you happen to know out of interest whether this will be in the next release then? Not too much trouble as I currently have a work around to install setuptools in the env the ci uses but would like to remove it
Describe the bug
pyfiglet version in elementary has a hidden dependency on setuptools on some versions of python (I believe > 3.11) that causes edr cli to fail with the following error message
This looks like it relates to this issue on pyfiglet repo here that has been fixed pwaller/pyfiglet#124
To Reproduce
Steps to reproduce the behavior:
(1) Clone repo
(2) Create then activate a virtual environment using a python version above 3.11, for example using pyenv you could do the following
(3) Install requirements
(4) Run
This should then return the error
Expected behavior
EDR command should run without failure and display elementary logo and a list of commands to get started
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):
Additional context
Add any other context about the problem here.
Would you be willing to contribute a fix for this issue?
Yes I have tested a fix for this that I will raise a PR for shortly
The text was updated successfully, but these errors were encountered: