Remove Generator in _quarantine_media_txn() (#17813)

element-hq · Oct 31, 2024 · 7987d5e · 7987d5e
1 parent 3ae80b0
commit 7987d5e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/17813.bugfix b/changelog.d/17813.bugfix
@@ -0,0 +1 @@
+Avoid lost data on some database query retries.
diff --git a/synapse/storage/databases/main/room.py b/synapse/storage/databases/main/room.py
@@ -1175,7 +1175,7 @@ def _quarantine_media_txn(
                 SET quarantined_by = ?
                 WHERE media_origin = ? AND media_id = ?
             """,
-            ((quarantined_by, origin, media_id) for origin, media_id in remote_mxcs),
+            [(quarantined_by, origin, media_id) for origin, media_id in remote_mxcs],
         )
         total_media_quarantined += txn.rowcount if txn.rowcount > 0 else 0
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Avoid lost data on some database query retries.