ShareDialog: fix share on Twitter URL #28886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point, X (Formerly known as Twitter) changed the URL to share Tweets. This changes it to the now correct URL. Signed-off-by: Ethan Carter Edwards <ethan@ethancedwards.com>
florianduros
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Thanks for the contribution.
Sharing in the PR the doc https://developer.x.com/en/docs/x-for-websites/tweet-button/overview if we need to get going back on it.
|
@ethancedwards8 the tests are in failure, can you fix them? |
|
I do not wish for this contribution to be considered any longer. Additionally, how may I revoke my CLA? @florianduros . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point, X (Formerly known as Twitter) changed the URL to share Tweets. This changes it to the now correct URL.
Checklist
public/exportedsymbols have accurate TSDoc documentation.