-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Advanced
section to the user settings encryption tab
#28804
Conversation
5055c46
to
85ce1cc
Compare
85ce1cc
to
32ec0d2
Compare
32ec0d2
to
6467943
Compare
a8dd23c
to
00a85d8
Compare
380ef62
to
8bd5d6a
Compare
00a85d8
to
a2a2512
Compare
9841d92
to
fd51450
Compare
fd51450
to
8f98a63
Compare
8f98a63
to
58d2f91
Compare
74c9a7b
to
7ddd021
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a crypto standpoint, looks sane. There's a wording thing that I'm not completely happy with, but it may be good enough.
"breadcrumb_first_description": "Your account details, contacts, preferences, and chat list will be kept", | ||
"breadcrumb_page": "Reset encryption", | ||
"breadcrumb_second_description": "You will lose any message history that’s stored only on the server", | ||
"breadcrumb_third_description": "You will need to verify all your existing devices and contacts again", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be a bit misleading, as it says that the user needs to verify all their contacts, whereas they really only need to re-verify contacts that they had already verified. Though I don't know how to word it better without being overly wordy. So maybe it's OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wording is coming from figma design
Checklist
public
/exported
symbols have accurate TSDoc documentation.Task #26468
Closes #28977
Required matrix-org/matrix-js-sdk#4614
Figma design
Add a new section to the encryption tab of the user settings. This section adds: