Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Advanced section to the user settings encryption tab #28804

Merged
merged 17 commits into from
Jan 24, 2025

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented Dec 23, 2024

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Task #26468
Closes #28977
Required matrix-org/matrix-js-sdk#4614
Figma design

Add a new section to the encryption tab of the user settings. This section adds:

  • Session id & session key
  • Import and export of room keys
  • Reset cryptographic identity
  • Blacklist to unverified device

@florianduros florianduros force-pushed the florianduros/advanced-section branch from 5055c46 to 85ce1cc Compare December 23, 2024 14:57
@florianduros florianduros force-pushed the florianduros/advanced-section branch from 85ce1cc to 32ec0d2 Compare December 23, 2024 15:24
@florianduros florianduros force-pushed the florianduros/advanced-section branch from 32ec0d2 to 6467943 Compare December 24, 2024 15:20
@florianduros florianduros force-pushed the florianduros/advanced-section branch 2 times, most recently from a8dd23c to 00a85d8 Compare January 8, 2025 13:46
@florianduros florianduros force-pushed the florianduros/encryption-tab branch from 380ef62 to 8bd5d6a Compare January 9, 2025 14:51
@florianduros florianduros force-pushed the florianduros/advanced-section branch from 00a85d8 to a2a2512 Compare January 13, 2025 09:31
Base automatically changed from florianduros/encryption-tab to develop January 15, 2025 12:59
@florianduros florianduros force-pushed the florianduros/advanced-section branch from 9841d92 to fd51450 Compare January 15, 2025 14:03
@florianduros florianduros force-pushed the florianduros/advanced-section branch from fd51450 to 8f98a63 Compare January 15, 2025 16:10
@florianduros florianduros force-pushed the florianduros/advanced-section branch from 8f98a63 to 58d2f91 Compare January 16, 2025 14:54
Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a crypto standpoint, looks sane. There's a wording thing that I'm not completely happy with, but it may be good enough.

"breadcrumb_first_description": "Your account details, contacts, preferences, and chat list will be kept",
"breadcrumb_page": "Reset encryption",
"breadcrumb_second_description": "You will lose any message history that’s stored only on the server",
"breadcrumb_third_description": "You will need to verify all your existing devices and contacts again",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be a bit misleading, as it says that the user needs to verify all their contacts, whereas they really only need to re-verify contacts that they had already verified. Though I don't know how to word it better without being overly wordy. So maybe it's OK.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording is coming from figma design

@florianduros florianduros added this pull request to the merge queue Jan 24, 2025
Merged via the queue into develop with commit ac565dc Jan 24, 2025
31 checks passed
@florianduros florianduros deleted the florianduros/advanced-section branch January 24, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement "reset cryptographic identity" flow in new Encryption settings
3 participants