notification issue fixed #1237
Closed
notification issue fixed #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,6 +37,7 @@ module.exports = React.createClass({ | |||
| }, | |||
|
|
|||
| render: function() { | |||
| if (this.state.showToolbar != true) return null; | |||
There was a problem hiding this comment.
I don't think it's legal to return null here. But anyway, this logic is in the wrong place; the logic for whether to show the toolbar or not belongs in the parent component (MatrixChat).
MatrixChat.render already has:
... if (Notifier.supportsDesktopNotifications() && !Notifier.isEnabled() && !Notifier.isToolbarHidden()) {
topBar = <MatrixToolbar />;
}
You just need to update Notifier.isToolbarHidden.
There was a problem hiding this comment.
Cool, though if the user clicked on block in the notification permission dialog, we are going to show you have disabled desktop notification right? The logic for that would come here right?
|
Well with that all logic moves to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Minhaz A V minhazav@gmail.com
Changes:
getInitialStatefrom Notification class and show (or not) the toolbar depending on response. Listener to deal with close dialog persistently modified.