Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inputs inside Field should grow to fill container #9344

Closed
jryans opened this issue Apr 1, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3104
Closed

Inputs inside Field should grow to fill container #9344

jryans opened this issue Apr 1, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3104
Assignees
@t3chguy
Labels
Help Wanted Extra attention is needed P2 T-Task Tasks for the team like planning Z-Community-PR Issue is solved by a community member's PR

Comments

@jryans
Copy link
Collaborator

jryans commented Apr 1, 2019

Should involve setting flex: 1 on .mx_Field input etc. A quick test suggests many of the width calcs for fields in Settings and elsewhere could be removed with this.
@jryans jryans added T-Task Tasks for the team like planning P2 Help Wanted Extra attention is needed labels Apr 1, 2019
@turt2live
Copy link
Member

Related: #8471

@jryans jryans mentioned this issue Jun 6, 2019
Merged
@t3chguy t3chguy mentioned this issue Jun 13, 2019
Merged
@t3chguy t3chguy self-assigned this Jun 13, 2019
@turt2live turt2live added the Z-Community-PR Issue is solved by a community member's PR label Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
Help Wanted Extra attention is needed P2 T-Task Tasks for the team like planning Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use flex: 1 for mx_Field to replace all the calc(100% - 20px) and more matrix-org/matrix-react-sdk
3 participants
@jryans @turt2live @t3chguy