Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New notification setting ordering is weird. #18048

Closed
ara4n opened this issue Jul 18, 2021 · 1 comment · Fixed by matrix-org/matrix-react-sdk#6406
Closed

New notification setting ordering is weird. #18048

ara4n opened this issue Jul 18, 2021 · 1 comment · Fixed by matrix-org/matrix-react-sdk#6406
Assignees
@turt2live
Labels
Sponsored T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Jul 18, 2021

[ on, off, noisy ] feels a bit weird. Shouldn't it be [ off, on, noisy ]? Was it a deliberate change?
@ara4n ara4n added the T-Defect label Jul 18, 2021
@gaelledel
Copy link

Yes sorry that was a mistake from me - I didn't mean to change the order. Please revert to original

@turt2live turt2live self-assigned this Jul 19, 2021
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 19, 2021
@turt2live
Revert order of notification setting radios
b31043b 
Follow-on from #6352
Fixes element-hq/element-web#18048
@turt2live turt2live mentioned this issue Jul 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
Sponsored T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert order of notification setting radios matrix-org/matrix-react-sdk
3 participants
@turt2live @ara4n @gaelledel