Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New room list: Invites seem to have tag settings now #14198

Closed
jryans opened this issue Jun 25, 2020 · 5 comments · Fixed by matrix-org/matrix-react-sdk#4867
Closed

New room list: Invites seem to have tag settings now #14198

jryans opened this issue Jun 25, 2020 · 5 comments · Fixed by matrix-org/matrix-react-sdk#4867
Assignees
@turt2live
Labels
A-Room-List

Comments

@jryans
Copy link
Collaborator

jryans commented Jun 25, 2020

image

Is that expected...? It's different from before at least.
@t3chguy
Copy link
Member

t3chguy commented Jun 25, 2020

image

@turt2live
Copy link
Member

I imagine we'll want to add an accept and reject button to this instead.

@turt2live
Copy link
Member

Temporary design: No context menu.

@turt2live turt2live self-assigned this Jul 1, 2020
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 1, 2020
@turt2live
Remove context menu on invites in new room list
ad98262 
Fixes element-hq/element-web#14198

For both, the decision has been made to not have a context menu pending further considerations of where invites should (and should not) be. Likely this will be dealt with in FTUE Notifications.
@turt2live turt2live mentioned this issue Jul 1, 2020
Merged
@t3chguy
Copy link
Member

t3chguy commented Jul 1, 2020

Depending on which of this and matrix-org/matrix-react-sdk#4858 land first the other has more work to do

@t3chguy
Copy link
Member

t3chguy commented Jul 1, 2020

okay, added the same logic to notifications context menu in above PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Room-List
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove context menu on invites in new room list matrix-org/matrix-react-sdk
3 participants
@jryans @turt2live @t3chguy