Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash if app soft-logged out on startup? #12943

Closed
dbkr opened this issue Mar 31, 2020 · 0 comments · Fixed by matrix-org/matrix-react-sdk#4353
Closed

Crash if app soft-logged out on startup? #12943

dbkr opened this issue Mar 31, 2020 · 0 comments · Fixed by matrix-org/matrix-react-sdk#4353
Labels
A-E2EE A-Soft-Logout https://github.com/element-hq/element-web/issues/10224 T-Defect X-Regression

Comments

@dbkr
Copy link
Member

dbkr commented Mar 31, 2020

Looks like we may have a regression where if Riot starts up and finds its access token is no longer valid due to a soft-logout, it tries to flag sessions for backup before it enables crypto, and soft-crashes.
@dbkr dbkr added T-Defect X-Regression A-E2EE A-Soft-Logout https://github.com/element-hq/element-web/issues/10224 labels Mar 31, 2020
dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 7, 2020
@dbkr
Don't try to send presence updates until the client is started
8d68a4a 
Otherwise we can start making API reqiests which can fail which
can trigger things like the soft logout code.

Fixes element-hq/element-web#12943
@dbkr dbkr mentioned this issue Apr 7, 2020
Merged
t3chguy pushed a commit that referenced this issue Oct 17, 2024
@langleyd
Update to 2.37.9 (#12943)
579cb6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE A-Soft-Logout https://github.com/element-hq/element-web/issues/10224 T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't try to send presence updates until the client is started matrix-org/matrix-react-sdk
1 participant
@dbkr