Something leaks '/undefined' into URLs when acting as a guest

[ara4n]

I just started a fresh incognito tab against my local develop vector. This put me as a guest in RoomDirectory view, but something rewrote the location bar as http://localhost:8080/#/room/undefined. I then hit refresh, which took me to a 'Join' page, presumably trying to join a room with room id of "undefined". This also breaks URL-keyed page stats :(

[mebjas]

What is the expected behavior here?
@ara4n

[ara4n]

The app should take you to RoomDirectory view on initial launch, but the URL should either be something explicit (like /directory) and certainly not /#/room/undefined.

[mebjas]

@ara4n now shows /directory

[ara4n]

I'm still seeing this happen - e.g. loading http://localhost:8080/#/login leaves me sitting at http://localhost:8080/#/room/undefined

[mebjas]

Lemme check

[mebjas]

@ara4n This is strange, loading http://localhost:8080/#/login took me to http://localhost:8080/#/directory

More pointers on steps to reproduce?

[ara4n]

gah, i think i was on an old feature branch - sorry :( on the plus side,
yay! i'll close this

On 15/03/2016 16:00, minhaz wrote:

@ara4n https://github.com/ara4n This is strange, loading
|http://localhost:8080/#/login| took me to
|http://localhost:8080/#/directory|

More pointers on steps to reproduce?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#1079 (comment)

[ara4n]

fixed - thanks @mebjas :)