Skip to content

Commit

Permalink
Iterate
Browse files Browse the repository at this point in the history
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
  • Loading branch information
t3chguy committed Jan 9, 2025
1 parent e519d2c commit d00ac8e
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 11 deletions.
7 changes: 3 additions & 4 deletions .github/workflows/end-to-end-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -216,23 +216,22 @@ jobs:
uses: actions/download-artifact@v4
with:
pattern: blob-report-*
path: all-blob-reports

# Ideally we'd use merge-multiple=true on download, but it is broken in certain cases
# https://github.com/microsoft/playwright/issues/29451
- name: Check report integrity
if: inputs.skip != true
run: |
for file in all-blob-reports/**/*.zip; do
for file in blob-report-*/*.zip; do
unzip -t $file
done
- name: Merge blob reports
if: inputs.skip != true
run: for z in all-blob-reports/**/*.zip; do unar -r "$z" -o all-blob-reports-merged; done
run: for z in blob-report-*/*.zip; do unar -r "$z" -o all-blob-reports; done

- name: Merge into HTML Report
if: inputs.skip != true
run: yarn playwright merge-reports --reporter=html,json,./playwright/flaky-reporter.ts,./playwright/stale-screenshot-reporter.ts ./all-blob-reports-merged
run: yarn playwright merge-reports --reporter=html,json,./playwright/flaky-reporter.ts,./playwright/stale-screenshot-reporter.ts ./all-blob-reports
env:
# Only pass creds to the flaky-reporter on main branch runs
GITHUB_TOKEN: ${{ github.ref_name == 'develop' && secrets.ELEMENT_BOT_TOKEN || '' }}
Expand Down
6 changes: 1 addition & 5 deletions knip.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,7 @@ export default {
"test/**",
"res/decoder-ring/**",
],
project: [
"**/*.{js,ts,jsx,tsx}",
// This throws an error trying to load tenbin - https://knip.dev/reference/known-issues#exceptions-from-config-files
"!src/playwright.config.ts",
],
project: ["**/*.{js,ts,jsx,tsx}"],
ignore: [
"docs/**",
"res/jitsi_external_api.min.js",
Expand Down
4 changes: 2 additions & 2 deletions playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ export default defineConfig({
snapshotDir: "playwright/snapshots",
snapshotPathTemplate: "{snapshotDir}/{testFilePath}/{arg}-{platform}{ext}",
forbidOnly: !!process.env.CI,
testMatch: process.env.CI
testMatch: process.env.SHARD
? splitTests({
shard: process.env.SHARD ?? "1/1",
shard: process.env.SHARD,
pattern: ["playwright/e2e/**/*.spec.ts"],
reportFile: "playwright-results.json",
})
Expand Down

0 comments on commit d00ac8e

Please sign in to comment.