Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flescio/7253 add mar kas unread option for rooms #7301

Merged
merged 7 commits into from
Jan 31, 2023
Merged

Flescio/7253 add mar kas unread option for rooms #7301

merged 7 commits into from
Jan 31, 2023

Conversation

flescio
Copy link
Contributor

@flescio flescio commented Jan 25, 2023

Resolves #7253

ezgif-2-b6a3523ed7

@flescio flescio requested review from amshakal, a team and aringenbach and removed request for a team January 25, 2023 16:23
@codecov
Copy link

codecov bot commented Jan 25, 2023 •
edited
Loading

Codecov Report

Base: 12.02% // Head: 12.03% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (728dd10) compared to base (4a2a057).
Patch coverage: 39.75% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #7301   +/-   ##
========================================
  Coverage    12.02%   12.03%           
========================================
  Files         1629     1628    -1     
  Lines       161185   161196   +11     
  Branches     66037    66040    +3     
========================================
+ Hits         19387    19392    +5     
- Misses      141154   141161    +7     
+ Partials       644      643    -1
Flag Coverage Δ
uitests 55.72% <73.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Modules/Analytics/DecryptionFailure.swift 0.00% <ø> (ø)
Riot/Modules/Analytics/DecryptionFailureTracker.m 35.22% <ø> (ø)
...alytics/Helpers/MXCallHangupReason+Analytics.swift 0.00% <0.00%> (ø)
...iot/Modules/Common/Recents/RecentsViewController.m 8.68% <0.00%> (-0.02%) ⬇️
...Modules/Common/Recents/Views/RecentTableViewCell.m 0.00% <0.00%> (ø)
...ntextMenu/ActionProviders/RoomActionProvider.swift 0.00% <0.00%> (ø)
...ontextMenu/Services/RoomContextActionService.swift 0.00% <0.00%> (ø)
...ules/MatrixKit/Models/RoomList/MXKRecentCellData.m 0.00% <0.00%> (ø)
Riot/Modules/Room/MXKRoomViewController.m 0.00% <0.00%> (ø)
Riot/Utils/EventFormatter.m 8.05% <0.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

aringenbach
aringenbach approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Riot/Modules/ContextMenu/Services/RoomContextActionServiceProtocol.swift Outdated
@@ -22,6 +22,7 @@ import Foundation
func roomContextActionService(_ service: RoomContextActionServiceProtocol, showRoomNotificationSettingsForRoomWithId roomId: String)
func roomContextActionServiceDidJoinRoom(_ service: RoomContextActionServiceProtocol)
func roomContextActionServiceDidLeaveRoom(_ service: RoomContextActionServiceProtocol)
func roomContextActionServiceDidMarkedRoom(_ service: RoomContextActionServiceProtocol)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose roomContextActionServiceDidMarkRoom will make more sense

amshakal
amshakal approved these changes Jan 27, 2023
View reviewed changes
Copy link

@amshakal amshakal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@flescio flescio merged commit 54602b6 into develop Jan 31, 2023
@flescio flescio deleted the flescio/7253-Add_mar_kas_unread_option_for_rooms branch January 31, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amshakal amshakal amshakal approved these changes

@aringenbach aringenbach aringenbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add mark as unread option for rooms
3 participants
@flescio @aringenbach @amshakal