Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate between types of "member" #2807

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

hughns
Copy link
Member

@hughns hughns commented Nov 20, 2024

We have Matrix room members and MatrixRTC session memberships. Livekit also has rooms.

So, this attempts to make it more obvious as to what type you are referring to.

We have Matrix room members and MatrixRTC session memberships. Livekit also has rooms.

So, this attempts to make it more obvious as to what type you are referring to.
@hughns hughns requested a review from a team as a code owner November 20, 2024 10:34
@hughns hughns changed the title Disambiguate between member types Disambiguate between types of "member" Nov 20, 2024
Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@hughns hughns merged commit 3885eef into livekit Nov 21, 2024
7 checks passed
@hughns hughns deleted the hughns/distinguish-members branch November 21, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants