Use optimized font from fontsource #2775
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the embedded font with a package from fontsource.
The @font-face declarations are way better, with the font being split depending on the font-weight, font-style, and unicode-range.
I also removed the custom font-family variables on desktop, so that we can get the carefully-crafted fallbacks from the compound-design-tokens.
Here is a side-by-side comparison for this patch:
Screen.Recording.2024-11-14.at.11.21.22.mov
You'll notice on the left that the font swap is barely noticeable (at 10s) compared to the right (at 22s) and that the fonts are way smaller to load.
I still kept the font overrides on Android/iOS, as I assume this is for better design in embedded mode on those platforms.