Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix (rust crypto): Adjust login procedures to account for rust crypto behaviour. #2603

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Fix (rust crypto): Adjust login procedures to account for rust crypto behaviour. #2603

merged 2 commits into from
Sep 2, 2024

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Sep 2, 2024

  • If we have an invalid access token return null so that we get prompted with the registration (create call without being authenticated) view.
  • logout the guest user, before we try to login (interactive login with username and pwd)
  • clear (and await) the rust crypto store before we initialize it in case we do not want to restore a localstore session.

@toger5 toger5 requested a review from a team as a code owner September 2, 2024 12:47
fkwp
fkwp approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@fkwp fkwp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@toger5
Fix interactive login with authenticated guest user.
4fa6d9f 
Fix clearing storage before logging in a new account.
@toger5 toger5 force-pushed the toger5/fix-rust-crypto branch from 070de0f to 4fa6d9f Compare September 2, 2024 14:43
@toger5
Copy link
Contributor Author

toger5 commented Sep 2, 2024

We will merge this without meeting the coverage requirements since our time can be used for more useful tests.

@toger5 toger5 merged commit 0402887 into livekit Sep 2, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkwp fkwp fkwp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toger5 @fkwp