Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Rust crypto implementation #2571

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Use Rust crypto implementation #2571

merged 2 commits into from
Aug 23, 2024

Conversation

hughns
Copy link
Member

@hughns hughns commented Aug 19, 2024

This isolates the Rust crypto based changes from #2467

@hughns hughns mentioned this pull request Aug 19, 2024
@hughns hughns marked this pull request as ready for review August 19, 2024 09:55
@hughns hughns requested a review from a team as a code owner August 19, 2024 09:55
@hughns hughns added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Aug 19, 2024
@hughns
Copy link
Member Author

hughns commented Aug 19, 2024

n.b. whilst we can review this now, we might want to wait until we merge it until we plan out how we will do #1281.

@hughns
Copy link
Member Author

hughns commented Aug 23, 2024

As per the discussion today, we should proceed with reviewing and merging this PR independent of #1281.

Copy link
Contributor

@fkwp fkwp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@robintown robintown merged commit 66b79f5 into livekit Aug 23, 2024
4 checks passed
@hughns hughns deleted the hughns/rust-crypto branch September 30, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants