Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove E2EE setting #1755

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Remove E2EE setting #1755

merged 2 commits into from
Oct 13, 2023

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Oct 13, 2023

Since e2ee is enabled by default now

Based on #1754

Since e2ee is enabled by default now
@dbkr dbkr added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Oct 13, 2023
@dbkr dbkr requested a review from a team as a code owner October 13, 2023 09:33
@dbkr dbkr changed the base branch from dbkr/remove_e2ee_banner to livekit October 13, 2023 14:19
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e86f9b7) 30.55% compared to head (ea1c2e9) 30.10%.

Additional details and impacted files
@@             Coverage Diff             @@
##           livekit    #1755      +/-   ##
===========================================
- Coverage    30.55%   30.10%   -0.46%     
===========================================
  Files           47       47              
  Lines         1882     1877       -5     
  Branches       329      327       -2     
===========================================
- Hits           575      565      -10     
- Misses        1260     1267       +7     
+ Partials        47       45       -2     
Flag Coverage Δ
unittests 30.10% <100.00%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/e2ee/sharedKeyManagement.ts 58.33% <100.00%> (+2.33%) ⬆️
src/settings/useSetting.ts 33.33% <ø> (-20.16%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbkr dbkr merged commit d94c412 into livekit Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants