Add skipLobby to params #1730
Merged
Add skipLobby to params #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo K <toger5@hotmail.de>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## livekit #1730 +/- ##
========================================
Coverage 29.96% 29.96%
========================================
Files 47 47
Lines 1879 1879
Branches 329 329
========================================
Hits 563 563
Misses 1272 1272
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
robintown
reviewed
Oct 11, 2023
robintown
added a commit
to robintown/matrix-react-sdk
that referenced
this pull request
Oct 13, 2023
The semantics of the preload parameter are changing as detailed here, meaning we now have to additionally specify skipLobby to get the desired behavior out of Element Call: element-hq/element-call#1730
robintown
added a commit
to robintown/matrix-react-sdk
that referenced
this pull request
Oct 13, 2023
The semantics of the preload parameter are changing as detailed here, meaning we now have to additionally specify skipLobby to get the desired behavior out of Element Call: element-hq/element-call#1730
robintown
approved these changes
Oct 13, 2023
github-merge-queue bot
pushed a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Oct 16, 2023
…11749) The semantics of the preload parameter are changing as detailed here, meaning we now have to additionally specify skipLobby to get the desired behavior out of Element Call: element-hq/element-call#1730
Signed-off-by: Timo K <toger5@hotmail.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously preload automatically was skipping the lobby. In our effort to make the url params more specific instead of hiding a bunch of changes behind one parameter that is named based on usage (
embedconfineToRoom...preloadpreload+skipLobby).Before preload was also skipping the lobby. Now its two different things so we can also skip the lobby without using preload (most likely for the mobile 1:1 call experience).
fixes: #1734