Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shell completion support #447

Merged
merged 1 commit into from
Apr 8, 2018
Merged

Conversation

malept
Copy link
Member

@malept malept commented Mar 10, 2018

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

tabtab is rather buggy and the alternative, commander-completion, needs a custom completion script to be written and maintained.

@malept malept requested a review from MarshallOfSound March 10, 2018 18:34
@malept malept changed the base branch from master to v6-api April 4, 2018 11:55
tabtab is rather buggy and the alternative, commander-completion, needs
a custom completion script to be written and maintained.
@malept malept force-pushed the remove-shell-completion branch from ddecef5 to fee83fe Compare April 4, 2018 12:04
@malept
Copy link
Member Author

malept commented Apr 4, 2018

I retargeted/rebased against v6-api.

@malept malept added this to the 6.0 milestone Apr 4, 2018
@malept malept changed the base branch from v6-api to v6 April 8, 2018 14:25
@malept malept changed the base branch from v6 to v6-api April 8, 2018 14:26
@MarshallOfSound MarshallOfSound merged commit 6c6c798 into v6-api Apr 8, 2018
@MarshallOfSound MarshallOfSound deleted the remove-shell-completion branch April 8, 2018 15:01
MarshallOfSound added a commit that referenced this pull request Apr 11, 2018
* temp

* Start working in new package structure

* Example maker

* All makers implemented and tests passing on darwin

* Add v6 branches to travis config

* Add v6 branches to appveyor config

* Gitignore _old

* Remove FIXME comments

* Remove from CI branch whitelist

* Install bolt on docker

* Add to whitelist

* Fix bolt usage on CI

* Run bolt build on CI

* Fix tests on CI

* Fix linting

* Fix CI

* Make publishers work and add specs

* Docs template

* Initial docs

* update plugin interface to support resolving strings

* more docs

* add deps and scripts

* send makeResults instead of flatten artifacts list

* feat(publisher): Allow to configure channel for ERS (#456)

* fix(publisher): call resolve() when electron-release-server publisher succeeds (#465)

ISSUES CLOSED: #460

* Fix publisher tests

* Remove stray console statement

* v6-api is a PR now, no need to explicitly add to CI

* Add top level license

* Change Maker/Publisher syntax so that they can be constructed with a config variable

* Fix custom init

* Allow absolute paths to custom modules
* Update to new @electron-forge/ scope

* Add missing semi

* Use absolute path for custom init to avoid runnig npm link on windows

* Fix appx test reference to fixture key file

* Remove shell completion support (#447)

tabtab is rather buggy and the alternative, commander-completion, needs
a custom completion script to be written and maintained.

* install new beta tagged bolt on CI

* Fix testing snap building in Travis

* fix remove error

* Fix config passing in tests

* fix search order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants