Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin gh-actions to SHAs, update to remove deprecation warning #2966

Merged
merged 2 commits into from
Oct 18, 2022

Conversation

VerteDinde
Copy link
Member

@VerteDinde VerteDinde commented Oct 14, 2022

This PR makes two changes to CI:

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

@VerteDinde VerteDinde force-pushed the update-node-gh-actions branch from 9164f9f to b888c50 Compare October 14, 2022 03:19
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #2966 (36d4529) into main (362099a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2966   +/-   ##
=======================================
  Coverage   73.80%   73.80%           
=======================================
  Files          66       66           
  Lines        2142     2142           
  Branches      424      424           
=======================================
  Hits         1581     1581           
  Misses        356      356           
  Partials      205      205           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 362099a...36d4529. Read the comment docs.

@VerteDinde VerteDinde changed the title fix: pin gh-actions to SHAs, update ci runs to Node 16 fix: pin gh-actions to SHAs, update to remove deprecation warning Oct 14, 2022
@VerteDinde VerteDinde marked this pull request as ready for review October 14, 2022 04:01
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passes lgtm

@erickzhao erickzhao merged commit fbc92e4 into main Oct 18, 2022
@erickzhao erickzhao deleted the update-node-gh-actions branch October 18, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The save-state command is deprecated and will be disabled soon.
2 participants