fix(plugin-webpack): properly reference index.js
in production
#1021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building an executable using
electron-forge make
, settingpublicPath
as/
leads (for example) toindex.js
being referenced asfile:///main_window/index.js
, which cannot be found. (The URL points to/main_window/index.js
, which is incorrect. It should be../main_window/index.js
.)When it is unset, the build runs properly and provides the correct URL. (This still works with
electron-forge start
as wellwith manual reloading.)Summarize your changes:
Removed the (apparently unnecessary) reference topublicPath
.Removed the reference to
publicPath
when building for production.