-
-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[webpack] allow specifying watch options for the dev server #594
Comments
I want to help with that, I just think we should figure out how to test the webpack plugin first, see #639 |
Bump to this issue. It seems to be a pretty serious shortcoming. The manual fix to WebpackPlugin.ts [including watcherOptions] also solved my CPU issue. In my case, I am writing a mid-sized React based app, and noticed Using boiler plate from docs, electron-forge-start.js was using 5% of CPU while idling. After change it uses 1%. So it seems that the CPU used scales with project size, and that the problem is only further exacerbated as project grows. |
Bump again on this issue. Fix seems simple, have had to apply this patch at least 8 times in the past month due to package updates / overwrites / reinstalls of node_modules on various dev machines. Is there any reason to just include these watch options in the default watcher config? |
* feat: get Fiddle content from electron-quick-start We fetch and cache a branch of electron-quick-start that corresponds to the Electron version being used. If this fails (e.g. if we're offline), fallback to the bundled files in `static/electron-quick-start/`.
On my computer i have some issue with electron-forge which uses all my cpu on start with wepback.
I think it's related to webpack watch feature.
To "improve" the situation i added options to the dev server [here] (https://github.com/electron-userland/electron-forge/blob/master/packages/plugin/webpack/src/WebpackPlugin.ts#L280)
Adding (doc):
made the CPU usage go down to 50%. Which is much better (though still not that good).
Could you add a way to pass options to the dev server through the webpack plugin configuration?
Thanks
The text was updated successfully, but these errors were encountered: