Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: depend on one lodash package #60

Merged
merged 2 commits into from
Jan 17, 2020
Merged

refactor: depend on one lodash package #60

merged 2 commits into from
Jan 17, 2020

Conversation

malept
Copy link
Member

@malept malept commented Jan 17, 2020

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Reduce the number of dependencies. electron-installer-common already depends on lodash.

@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #60   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      8           
  Lines         253    252    -1     
=====================================
- Hits          253    252    -1
Impacted Files Coverage Δ
src/yaml.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 807e4e2...facaef7. Read the comment docs.

@malept malept merged commit dcf2cf9 into master Jan 17, 2020
@malept malept deleted the consolidate-lodash branch January 17, 2020 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant