refactor: rename options.os to options.platform (#196)

README.md

@@ -275,11 +275,11 @@ Default: `undefined`
 
 Machine architecture the package is targeted to, used to set the `--target` option.
 
-#### options.os
+#### options.platform
 Type: `String`
-Default: Operating system platform of the host machine
+Default: Operating system platform of the host machine. For possible values see Node.js [process.platform](https://nodejs.org/api/process.html#process_process_platform)
 
-Operating system platform the package is targeted to, used to set the `--target` option.
+Operating system platform the package is targeted to, used to set the [`--target`](https://linux.die.net/man/8/rpmbuild) option.
 
 #### options.requires
 Type: `Array[String]`

src/installer.js

@@ -59,7 +59,7 @@ class RedhatInstaller extends common.ElectronInstaller {
   async createPackage () {
     this.options.logger(`Creating package at ${this.stagingDir}`)
 
-    const output = await spawn('rpmbuild', ['-bb', this.specPath, '--target', `${this.options.arch}-${this.options.vendor}-${this.options.os}`, '--define', `_topdir ${this.stagingDir}`], this.options.logger)
+    const output = await spawn('rpmbuild', ['-bb', this.specPath, '--target', `${this.options.arch}-${this.options.vendor}-${this.options.platform}`, '--define', `_topdir ${this.stagingDir}`], this.options.logger)
     this.options.logger(`rpmbuild output: ${output}`)
   }
 
@@ -128,7 +128,7 @@ class RedhatInstaller extends common.ElectronInstaller {
     this.normalizeVersion()
 
     this.options.vendor = 'none'
-    this.options.os = this.options.os || process.platform
+    this.options.platform = this.options.platform || process.platform
   }
 
   /**

test/installer.js

@@ -170,7 +170,7 @@ describe('module', function () {
         src: 'test/fixtures/app-with-asar/',
         options: {
           arch: 'x86',
-          os: 'linux'
+          platform: 'linux'
         }
       },
       'generates a `.rpm` package with linux %_target_os',