Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize package names to conform to Debian policy #170

Merged
merged 3 commits into from
Jan 5, 2019

Conversation

malept
Copy link
Member

@malept malept commented Jan 5, 2019

Reference: https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-source

Addresses electron/forge#654

Also:

  • Clean up -common imports
  • Add test helper describeInstallerWithException

It might be easier to look at the changes in each commit.

@malept malept requested a review from fcastilloec January 5, 2019 18:16
Copy link
Collaborator

@fcastilloec fcastilloec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! We never checked the names because we assumed that it'll be using whatever it's in package.json which has a very similar policy for names as Debian. I'm glad we're being as thorough as possible to eliminate undocumented errors for users.

@fcastilloec fcastilloec merged commit 5895cb5 into master Jan 5, 2019
@fcastilloec fcastilloec deleted the sanitize-name branch January 5, 2019 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants