Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transformVersion as an exportable function #144

Merged
merged 2 commits into from
Oct 4, 2018
Merged

Add transformVersion as an exportable function #144

merged 2 commits into from
Oct 4, 2018

Conversation

malept
Copy link
Member

@malept malept commented Oct 3, 2018

Allows other modules to transform a SemVer version into a Debian-style version.

I'd like to add this because it's needed to fix an Electron Forge bug.

@malept
Add transformVersion as an exportable function
0093e62 
Allows other modules to transform a SemVer version into a Debian-style
version.
@malept malept requested a review from fcastilloec October 3, 2018 02:32
@malept malept mentioned this pull request Oct 3, 2018
Closed
@malept malept force-pushed the transform-version-api branch from 65c880f to 0093e62 Compare October 3, 2018 03:33
fcastilloec
fcastilloec approved these changes Oct 3, 2018
View reviewed changes
Copy link
Collaborator

@fcastilloec fcastilloec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's nothing that really changed here, so I'll approve it. I'm guessing electron-forge is going to use our transformVersion function to find the package.

@malept
Copy link
Member Author

malept commented Oct 3, 2018

I'm guessing electron-forge is going to use our transformVersion function to find the package.

That's the plan.

@malept malept merged commit 82ad864 into master Oct 4, 2018
@malept malept deleted the transform-version-api branch October 4, 2018 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcastilloec fcastilloec fcastilloec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish does not find generated deb alpha package
2 participants
@malept @fcastilloec