fix: ensure scripts have the executable bit set (#211)

electron-userland · Aug 29, 2019 · 21e715f · 21e715f
1 parent 4d6a3f4
commit 21e715f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/installer.js b/src/installer.js
@@ -67,12 +67,13 @@ class DebianInstaller extends common.ElectronInstaller {
     const scriptNames = ['preinst', 'postinst', 'prerm', 'postrm']
 
     return common.wrapError('creating script files', async () =>
-      Promise.all(_.map(this.options.scripts, (item, key) => {
+      Promise.all(_.map(this.options.scripts, async (item, key) => {
         if (scriptNames.includes(key)) {
           const scriptFile = path.join(this.stagingDir, 'DEBIAN', key)
           this.options.logger(`Creating script file at ${scriptFile}`)
 
-          return fs.copy(item, scriptFile)
+          await fs.copy(item, scriptFile)
+          return fs.chmod(scriptFile, 0o755)
         } else {
           throw new Error(`Wrong executable script name: ${key}`)
         }

diff --git a/test/fixtures/debian-scripts/preinst.sh b/test/fixtures/debian-scripts/preinst.sh