-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS: bug in the multi-architecture target specification #7683
Comments
Can you try the direct notarize integration within electron-builder?
|
Thank you very much for your response. Aside from import dotenv from "dotenv";
import { build } from "electron-builder";
dotenv.config();
build({
config: {
productName: "App",
artifactName: "${productName}-${version}-${platform}-${arch}.${ext}",
directories: {
output: "release",
},
mac: {
notarize: {
// @ts-ignore
tool: "notarytool",
teamId: process.env.TEAM_ID,
appleId: process.env.APPLE_ID,
appleIdPassword: process.env.APPLE_APP_SPECIFIC_PASSWORD,
},
},
},
}); |
You only need these vars: electron-builder/packages/app-builder-lib/src/options/macOptions.ts Lines 218 to 234 in e641ec9
The apple ID and password just are pulled from the environment automatically (it was deliberate to not allow them be stored in the config for security reasons) |
I am very sorry for the delay in responding to you. import dotenv from "dotenv";
import { build } from "electron-builder";
dotenv.config();
build({
config: {
productName: "Sample",
artifactName: "${productName}-${version}-${platform}-${arch}.${ext}",
mac: {
appId: "jp.wassabie64.Sample",
category: "public.app-category.developer-tools",
target: [
{
target: "default",
arch: ["arm64", "x64"],
},
],
notarize: {
appBundleId: "jp.wassabie64.Sample",
teamId: "**********",
},
},
},
}); |
How come this bug is closed if it's still happening? on package.json notarizing using notarytool doesn't work and altool's EOL date. keeps getting closer. |
Wait, so what's the bug? Using the To contribute, it's easy to set up a dev environment |
@mmaietta direct integration of electron/notarize package via notarize configuration option doesn't work if setting tool as notarytool, it always ends up using altool, once we reach Nov. 1st. this will be broken entirely, as altool won't be able to upload files to notarize on Apple's servers. EDIT: When also using the afterSign hook, even if setting the options in the notarize function where tool: "notarytool", also calls altool and get the warning regarding Nov. 1st. |
Looking at the notary code, it appears that if you include legacy fields in the configuration (such as |
It looks like these are the only fields you can include that won't trigger
Plus |
Ok, I've got a working solution, but it took me reading the source for both this project and Set these two environment variables on your build environment, as shown used here:
Then, in your config file, set ONLY the
If you set additional fields (such as |
Hi @duereg, i bumped into the same issue and followed the same steps as provided. Now i am running into the below error |
When multiple architectures are specified in target, electron-notarize's notarytool mode is not enabled.
It seems like a bug in builder.
Please see @electron/notarize's issues: #148 and #150.
The text was updated successfully, but these errors were encountered: