remove mongodb auth from logs #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 170
💛 - Coveralls |
|
Totally missed that the mongodb URI can contains username and password. Thanks for the PR. I will take a look at it later this week! |
electerious
added a commit
that referenced
this pull request
Sep 28, 2019
|
Implemented 👍 I've switched to normalizeUrl because it's already in use, widely tested and has a |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting mongodb secrets in logs is a bad idea, so I just wrote a small function to remove the username and the password from the logs.
I tried to keep consistent with the general coding style and added a test for the util function that I created. Don't hesitate to tell if you want anything changed!