-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ref, source and utm_source as referrer #173
Conversation
I am having trouble figuring out how to change the URL scalar to a union in the GraphQL API as I am not ver familiar with this. Also currently the UI displays an error as it expects the referrer id to be a URL not a string, |
Pull Request Test Coverage Report for Build 640
💛 - Coveralls |
Pull Request Test Coverage Report for Build 639
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍 Please let me know when the two comments are resolved. I will merge it into a dedicated branch and add the GraphQL part tomorrow so you can continue with ackee-track if you want.
Resolved the issues. The union idea didn't work out. I've adjusted the GraphQL schema to return a String for the referrer id. It now needs a isUrl function in the UI to detect URLs (the currently list only works with URLs). |
electerious/ackee-tracker#27 adds support for this feature to the tracker. |
Backend implementation to fix #169