Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ref, source and utm_source as referrer #173

Merged
merged 4 commits into from
Oct 25, 2020
Merged

Add ref, source and utm_source as referrer #173

merged 4 commits into from
Oct 25, 2020

Conversation

BetaHuhn
Copy link
Contributor

Backend implementation to fix #169

@BetaHuhn BetaHuhn mentioned this pull request Oct 24, 2020
@BetaHuhn
Copy link
Contributor Author

I am having trouble figuring out how to change the URL scalar to a union in the GraphQL API as I am not ver familiar with this. Also currently the UI displays an error as it expects the referrer id to be a URL not a string,

@coveralls
Copy link

coveralls commented Oct 24, 2020

Pull Request Test Coverage Report for Build 640

  • 9 of 15 (60.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 45.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/aggregations/aggregateNewFields.js 3 4 75.0%
src/aggregations/aggregateRecentFields.js 3 4 75.0%
src/aggregations/aggregateTopFields.js 3 4 75.0%
src/database/referrers.js 0 3 0.0%
Totals Coverage Status
Change from base Build 635: -0.3%
Covered Lines: 434
Relevant Lines: 767

💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 24, 2020

Pull Request Test Coverage Report for Build 639

  • 9 of 15 (60.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 45.155%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/aggregations/aggregateNewFields.js 3 4 75.0%
src/aggregations/aggregateRecentFields.js 3 4 75.0%
src/aggregations/aggregateTopFields.js 3 4 75.0%
src/database/referrers.js 0 3 0.0%
Totals Coverage Status
Change from base Build 635: -0.1%
Covered Lines: 434
Relevant Lines: 767

💛 - Coveralls

@BetaHuhn BetaHuhn marked this pull request as draft October 24, 2020 13:17
Copy link
Owner

@electerious electerious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 Please let me know when the two comments are resolved. I will merge it into a dedicated branch and add the GraphQL part tomorrow so you can continue with ackee-track if you want.

src/aggregations/aggregateNewFields.js Show resolved Hide resolved
src/types/records.js Show resolved Hide resolved
@electerious electerious changed the base branch from develop to feature/source October 25, 2020 08:55
@electerious electerious marked this pull request as ready for review October 25, 2020 13:00
@electerious electerious merged commit 306b1f4 into electerious:feature/source Oct 25, 2020
electerious added a commit that referenced this pull request Oct 25, 2020
@electerious
Copy link
Owner

Resolved the issues. The union idea didn't work out. I've adjusted the GraphQL schema to return a String for the referrer id. It now needs a isUrl function in the UI to detect URLs (the currently list only works with URLs).

@BetaHuhn
Copy link
Contributor Author

electerious/ackee-tracker#27 adds support for this feature to the tracker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants