Set cookie after login to ignore own visits

[yehudab]

Fix #100

[coveralls]

Pull Request Test Coverage Report for Build 613

• 2 of 13 (15.38%) changed or added relevant lines in 1 file are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.7%) to 45.78%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/resolvers/tokens.js	2	13	15.38%

Files with Coverage Reduction	New Missed Lines	%
src/resolvers/tokens.js	2	14.29%

Totals
Change from base Build 604:	-0.7%
Covered Lines:	455
Relevant Lines:	793

---

💛 - Coveralls

[yehudab]

@electerious
Any idea how I can re-run the above build?
Coverage on my local testing looks better now after the new commit.

[electerious]

1. Is my assumption correct that this only works when process.env.ACKEE_ALLOW_ORIGIN is available? This isn't always the case as process.env.ACKEE_ALLOW_ORIGIN is just a fallback for those not using a reverse proxy.

2. Let's say Ackee runs on ackee.example.com. It creates a cookie for example.com because this is the matching parent domain. Would it still ignore requests from example2.com?

My idea was that Ackee creates a cookie for the current domain (e.g. ackee.example.com) and a request will contain this cookie (e.g. from example2.com) so Ackee can ignore it. I'm however not sure if that's possible, because of blocked third party cookies. I want to ensure that it works without process.env.ACKEE_ALLOW_ORIGIN.

[yehudab]

1. Is my assumption correct that this only works when process.env.ACKEE_ALLOW_ORIGIN is available? This isn't always the case as process.env.ACKEE_ALLOW_ORIGIN is just a fallback for those not using a reverse proxy.

Yes, this was my plan. I wasn't aware that using ACKEE_ALLOW_ORIGIN is optional

2. Let's say Ackee runs on ackee.example.com. It creates a cookie for example.com because this is the matching parent domain. Would it still ignore requests from example2.com?

In this case, only results from example.com will be ignored

My idea was that Ackee creates a cookie for the current domain (e.g. ackee.example.com) and a request will contain this cookie (e.g. from example2.com) so Ackee can ignore it. I'm however not sure if that's possible, because of blocked third party cookies. I want to ensure that it works without process.env.ACKEE_ALLOW_ORIGIN.

Got it. I'll try a different approach and see if I cover both 1 and 2 above.

[yehudab]

Pushed another version.
I still need to test it to make sure it's working well and to resolve the above conflicts.
Notice that there is still a change needed in ackee-tracker part (also pushed)

[yehudab]

@electerious
After a few more checks and fixes, I think that the PR is ready and covers the flow mentioned in your comment from yesterday.
I don't have two domains to test example.com and example2.com, but I think that it should work.

[electerious]

Great work! Just a few small things and it's ready to be merged :)

[electerious]

There's a new function in src/utils/connect that can be used here.

[yehudab]

Done

[electerious]

Please run npm run lint to align the code with the rest.

[yehudab]

Fixed here and in other files in this PR

[electerious]

Let's create a small util for this as it's used in two places. isLoggedIn(res) => true/false in src/utils/.

[yehudab]

Good idea. Done.
One small change: Parameter name will be req, not res

[electerious]

Thanks for the great work 🙌

[electerious]

There's now an ignore-own-visits branch for both Ackee and ackee-tracker. I will do some testing on my server and on Netlify. This might take a while, but I'm sure that it will be part of the next release.

The biggest outcome for me is 'MongoMemoryServer'. Haven't seen it before and it's great to add tests for all MongoDB related files. More tests are welcome (can be based on the electerious:feature/ignore-own-visits branch) if you want to help out with more contributions :)

[yehudab]

Happy to help with the feature and the testing.
I willl do my best to add more tests.