Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "Deploy to Heroku" button #154

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Fix for "Deploy to Heroku" button #154

merged 1 commit into from
Sep 8, 2020

Conversation

katriellucas
Copy link
Contributor

As the title says, removed the deprecated dependecies (mLab addon), added some important (I think) environment variables in the the app creation. Now you directly need to link a database (e.g., MongoDB Atlas) to use Ackee.

Here is an example button:

Deploy

@coveralls
Copy link

coveralls commented Sep 6, 2020

Pull Request Test Coverage Report for Build 554

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.547%

Totals Coverage Status
Change from base Build 543: 0.0%
Covered Lines: 448
Relevant Lines: 772

💛 - Coveralls

@electerious electerious changed the base branch from master to develop September 6, 2020 19:00
@electerious
Copy link
Owner

Thanks @Go-Merk!

@aleccool213 You're my Heroku specialist 😃 Does this look good to you?

@@ -16,11 +16,22 @@
"ACKEE_PASSWORD": {
"description": "Password which will be used to log in to Ackee",
"required": true
},
"ACKEE_MONGODB": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea putting this in. I didn't originally put this in because the add-on put in a mongo db uri env var automatically.

}
},
"addons": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there docs saying which third party mongo dbs are best to use?

Copy link
Contributor Author

@katriellucas katriellucas Sep 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, for now I'm using Atlas which is basically mLab (is now part of MongoDB, Inc) making then some sort of official database, it's still the 500mb storage, #149 issue shows some free database hosting companies, Kintohub was the best in my opinion.

@electerious electerious merged commit 1856142 into electerious:develop Sep 8, 2020
@katriellucas katriellucas deleted the heroku-fix branch September 8, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants