Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show only active records in visitor counter #161

Closed
electerious opened this issue Sep 15, 2020 · 1 comment
Closed

Show only active records in visitor counter #161

electerious opened this issue Sep 15, 2020 · 1 comment

Comments

@electerious
Copy link
Owner

electerious commented Sep 15, 2020

The current implementation shows all records that have been updated in the last 30 seconds. A user that navigates between pages will therefore increase the counter temporary.

We should improve the aggregation to only show non-anonymized data (the most recent visit of a user): https://github.com/electerious/Ackee/blob/master/src/aggregations/aggregateActiveVisitors.js

The check can be the same as for unique views: https://github.com/electerious/Ackee/blob/master/src/aggregations/aggregateViews.js#L21

Original report: electerious/ackee-tracker#24

@electerious
Copy link
Owner Author

Fixed. Will be part of the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant