Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10: CSP WIP #14

Merged
merged 5 commits into from
Dec 16, 2021
Merged

10: CSP WIP #14

merged 5 commits into from
Dec 16, 2021

Conversation

eldang
Copy link
Owner

@eldang eldang commented Dec 15, 2021

Resolves #10 and some minor related issues.

@eldang eldang marked this pull request as ready for review December 15, 2021 21:19
@eldang eldang requested a review from coregis December 15, 2021 21:19
@eldang
Copy link
Owner Author

eldang commented Dec 15, 2021

@coregis this is ready now, and the code is running on my server.

Copy link
Collaborator

@coregis coregis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work! I still don't totally understand the nuances of the CSP updates (particularly the bit about ambiguous location of workers spawned by Mapbox..?) so maybe we can review that briefly next time we talk/screenshare. The BHS folks were very happy with the map, and I will add their limited set of revision requests to the Issues section of this repo

@coregis coregis merged commit 73b23fa into main Dec 16, 2021
@eldang
Copy link
Owner Author

eldang commented Dec 16, 2021

@coregis I must admit that there are still some things I don't understand, particularly that issue about where the workers are. Firefox, Chrome and Safari all give maddeningly different error feedback too, but between the three I at least figured out what I needed to do, if not exactly why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hosting this site at eldang.xyz fails
2 participants