Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Husky pre-commit hook to update the Playground docker image version #75

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

elchininet
Copy link
Owner

Every time that the @playwright/test is updated, the .playwright_docker_version gets outdated. If it is a patch update nothing happens, but if it is a major/minor update multiple times the tests fail because the versin of the Docker image and the version of the package don't match, so a manual work is required in those cases. This is pretty common during Dependabot updates.

This pull request creates a small Husky hook before any commit to check if the @playwright/test package has been updated. If the package has been updated, it updates the .playwright_docker_version file with the proper version and add it to the commit changes.

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 443d79e on create_husky_pre_commit_hook
into 3747fb5 on master.

@elchininet elchininet merged commit 5fd1038 into master Apr 15, 2024
2 checks passed
@elchininet elchininet deleted the create_husky_pre_commit_hook branch April 15, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants