Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "lovelace" string from all the events #32

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

elchininet
Copy link
Owner

  • Breaking change: Removed "lovelace" string from all the events because these events can be triggered on any dashboard if the listen method is called. The new even names are:
    • ON_PANEL_LOAD (onPanelLoad)
    • ON_MORE_INFO_DIALOG_OPEN (onMoreInfoDialogOpen)
    • ON_HISTORY_AND_LOGBOOK_DIALOG_OPEN (onHistoryAndLogBookDialogOpen)
    • ON_SETTINGS_DIALOG_OPEN (onSettingsDialogOpen)
  • Fix a bug: if one of the elements in a tree is null, return null instead of trying to perform a query on a null element which will throw an error

Note:

  1. In this pull request, the Home Assistant docker image has been updated to 2023.12.4.
  2. The Cypress version has been rolled back because the version 13.6.2 fails the tests almost all the time

@elchininet elchininet added bug Something isn't working refactor labels Jan 2, 2024
@coveralls
Copy link

coveralls commented Jan 2, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling bbcb6b4 on remove_lovelace_from_events
into 86d5b17 on master.

@elchininet elchininet merged commit 662f8d2 into master Jan 2, 2024
2 checks passed
@elchininet elchininet deleted the remove_lovelace_from_events branch January 2, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants