-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import order to pass linting #47
Comments
Can you send a PR?
…On Thu, Aug 31, 2017, 3:10 AM Alex Dadgar ***@***.***> wrote:
Hey it would be great if the import order followed the go style guide
<https://github.com/golang/go/wiki/CodeReviewComments#imports>. The side
effect of this is that projects that lint fail because of the generated
code.
The imports should look like:
package agent
import (
"bytes"
"compress/gzip"
"fmt"
"io"
"io/ioutil"
"os"
"path/filepath"
"strings"
"time"
"github.com/elazarl/go-bindata-assetfs"
)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#47>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAP4oi1flcpWUm9cA5i6euANifnPeymHks5sdfoKgaJpZM4PIIcc>
.
|
@elazarl Sorry I am not familiar with the code base and glancing through it I couldn't find the relevant part of the code base. |
Unfortunately I don't have much time for this project, and better project
exists, e.g., rice.go.
Thanks for the bug report!
…On Thu, Aug 31, 2017 at 8:21 PM, Alex Dadgar ***@***.***> wrote:
@elazarl <https://github.com/elazarl> Sorry I am not familiar with the
code base and glancing through it I couldn't find the relevant part of the
code base.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#47 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAP4ouKKe2flDeggiSEdW2pilRhfF8MMks5sdut9gaJpZM4PIIcc>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey it would be great if the import order followed the go style guide. The side effect of this is that projects that lint fail because of the generated code.
The imports should look like:
The text was updated successfully, but these errors were encountered: