RM-48543 always generate identifiers property for Social History #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaowb
reviewed
Feb 28, 2024
| @@ -43,6 +43,9 @@ var exportSocialHistorySection = function (version) { | |||
| } | |||
| delete this.js.nullCodeReplacementText; | |||
| } | |||
| if (!_.has(this, "js.identifiers")) { | |||
| this.js.identifiers = [{"identifier": null}]; | |||
There was a problem hiding this comment.
Hey I'm just curious because I don't really understand what I'm reading here
https://github.com/search?q=repo%3Aelationemr%2Fblue-button%20identifiers&type=code
It looks like "identifiers" is defined as "0..*" field in this file (line 23). Should it be changed as well ?
There was a problem hiding this comment.
yeah, when the xml has nullFlavor it'll get ignored <id nullFlavor="UNK"/>, it won't get parsed. This code is in another blue-button-xml repo.
landonbedell
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IdentifierswithIdentifiernull, so hippo can always expect property existsRM-48543