-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs][ML]Updates prebuilt ml jobs file links #918
[Docs][ML]Updates prebuilt ml jobs file links #918
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
These {anomaly-jobs} appear by default in the Anomaly Detection interface of the | ||
{siem-guide}/machine-learning.html[SIEM app] in {kib}. They help you | ||
automatically detect file system and network anomalies on your hosts. The list | ||
below contains the jobs organized by `agent.type` (Auditbeat, Packetbeat, and | ||
Winlogbeat). | ||
|
||
// tag::siem-jobs[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems likely to work fine, though for future reference I think it's fine to just make them as external links (i.e. use xxx.html instead of <>) in the context of both books. That's what we did for links in release highlights and breaking changes (e.g. https://www.elastic.co/guide/en/elastic-stack/current/elasticsearch-highlights.html) which are re-used in both the Installation/Upgrade Guide and individual product books.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do this now as it keeps thing simple.
@szabosteve - can you just give this another quick look? I updated as Lisa suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
* include link test * fixes links * removes SIEM changes * swaps atts for refs
* include link test * fixes links * removes SIEM changes * swaps atts for refs
Updates links in the ML SIEM prebuilt jobs section so it can be included in the SIEM docs without breaking links.