Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds screenshots to regression example #842

Merged
merged 7 commits into from
Feb 7, 2020

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Feb 6, 2020

@lcawl lcawl added v7.6.1 and removed WIP Work in progress v7.6.0 labels Feb 6, 2020
@lcawl lcawl marked this pull request as ready for review February 6, 2020 23:35
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text looks good! Left a few minor comments.

Use the {ref}/start-dfanalytics.html[start {dfanalytics-jobs}] API to start the
job. It will stop automatically when the analysis is complete.
The job takes a few minutes to run. Runtime depends on the local hardware and
also on the number of documents and fields that analyzed. The more fields and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing "are" in "... and field that analyzed"


////
TBD: Can we provide tips for what are good MSE or R-squared values? For example:
A MSE of zero means that the models predicts the dependent variable with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works just fine! Only one suggestion below

A MSE of zero means that the models predicts the dependent variable with
perfect accuracy. This is the ideal, but is typically not possible. Likewise, an
R-squared value of 1 indicates that all of the variance in the dependent variable
can be predicted from the feature variables. Typically, you compare the MSE and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"can be predicted from the feature variables" -> "can be explained by the feature variables"

@lcawl lcawl merged commit 2c84796 into elastic:master Feb 7, 2020
@lcawl lcawl deleted the kibana-regression branch February 7, 2020 17:06
@lcawl lcawl added v7.6.0 and removed v7.6.1 labels Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants