Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Spell check and minor tidying up of Infrastructure Monitoring Guide #476

Merged
merged 5 commits into from
Sep 4, 2019

Conversation

Titch990
Copy link
Contributor

@Titch990 Titch990 commented Aug 29, 2019

Minor changes and reorg, for consistency and logic.
There are more changes to follow, and some outstanding questions to resolve, for which I'll raise separate issues as necessary.

Part of https://github.com/elastic/observability-dev/issues/104.

Hi @elastic/infrastructure. Could I get a review on this, please? Docs build can be seen here http://stack-docs_476.docs-preview.app.elstc.co/guide/en/infrastructure/guide/master/index.html

@Titch990
Copy link
Contributor Author

Titch990 commented Sep 2, 2019

Pinging @bmorelli25 and @elastic/infrastructure. Could I have a review, please?

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look and answered some of the inline questions, this probably needs another look by someone from @elastic/infra-logs-ui

@Titch990
Copy link
Contributor Author

Titch990 commented Sep 3, 2019

@jsoriano. Thanks for taking the time to give such detailed answers. Perhaps I should have been a bit clearer - the comments were really placeholders for me to ensure I picked up the more detailed issues at some point. For now, I simply wanted to get some updated content out there. But I've got some answers too now! Thank you :-)

@Titch990 Titch990 force-pushed the MJ-inframon-spell-check branch from 8d0f8d4 to 701c818 Compare September 4, 2019 15:34
@Titch990 Titch990 merged commit 7ea92d1 into elastic:master Sep 4, 2019
@Titch990 Titch990 deleted the MJ-inframon-spell-check branch September 4, 2019 15:54
Titch990 added a commit to Titch990/stack-docs that referenced this pull request Sep 4, 2019
…Guide (elastic#476)

* More changes for consistency, style etc.

* Few more changes

* Moving info about metrics used into separate topic

* Few more edits

* Review comments

# Conflicts:
#	docs/en/infraops/overview.asciidoc
Titch990 added a commit to Titch990/stack-docs that referenced this pull request Sep 4, 2019
…Guide (elastic#476)

* More changes for consistency, style etc.

* Few more changes

* Moving info about metrics used into separate topic

* Few more edits

* Review comments

# Conflicts:
#	docs/en/infraops/overview.asciidoc
Titch990 added a commit to Titch990/stack-docs that referenced this pull request Sep 4, 2019
…Guide (elastic#476)

* More changes for consistency, style etc.

* Few more changes

* Moving info about metrics used into separate topic

* Few more edits

* Review comments

# Conflicts:
#	docs/en/infraops/overview.asciidoc
Titch990 added a commit that referenced this pull request Sep 4, 2019
…Guide (#476) (#487)

* More changes for consistency, style etc.

* Few more changes

* Moving info about metrics used into separate topic

* Few more edits

* Review comments

# Conflicts:
#	docs/en/infraops/overview.asciidoc
Titch990 added a commit that referenced this pull request Sep 4, 2019
…Guide (#476) (#488)

* More changes for consistency, style etc.

* Few more changes

* Moving info about metrics used into separate topic

* Few more edits

* Review comments

# Conflicts:
#	docs/en/infraops/overview.asciidoc
Titch990 added a commit that referenced this pull request Sep 4, 2019
…Guide (#476) (#489)

* More changes for consistency, style etc.

* Few more changes

* Moving info about metrics used into separate topic

* Few more edits

* Review comments

# Conflicts:
#	docs/en/infraops/overview.asciidoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants