Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fix problems in ingest management docs found during testing #1194

Merged
merged 10 commits into from
Jun 17, 2020

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Jun 17, 2020

This PR fixes issues identified by @bmorelli25 during doc testing.

This PR has a dependency on elastic/beats#19252. CI will fail until the beats PR is merged.

You won't be able to see an HTML preview until after the agent PR is merged

@dedemorton dedemorton marked this pull request as ready for review June 17, 2020 18:21
@dedemorton dedemorton self-assigned this Jun 17, 2020
@dedemorton dedemorton requested a review from bmorelli25 June 17, 2020 18:21
@dedemorton dedemorton changed the title [DOCS] Fix problems found during doc testing [DOCS] Fix problems in ingest management docs found during testing Jun 17, 2020
@dedemorton dedemorton changed the title [DOCS] Fix problems in ingest management docs found during testing [WIP][DOCS] Fix problems in ingest management docs found during testing Jun 17, 2020
@dedemorton dedemorton changed the title [WIP][DOCS] Fix problems in ingest management docs found during testing [DOCS] Fix problems in ingest management docs found during testing Jun 17, 2020
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dedemorton dedemorton merged commit d687462 into elastic:master Jun 17, 2020
@dedemorton dedemorton deleted the ingest_mgmt_cleanup branch June 17, 2020 21:28
dedemorton added a commit to dedemorton/stack-docs that referenced this pull request Jun 17, 2020
…lastic#1194)

* [DOCS] Fix problems found during doc testing

* Fix attribute resolution in example

* Mark all topics as licensed (xpack)

* Capitalize Agent to match current style guidelines

* Fix package registry and port

* Add limitations link to getting started

* Add experimental tag to all topics

* More changes to capitalize Agent

* Fix TIP formatting to include output

* A few more issues found during testing
dedemorton added a commit to dedemorton/stack-docs that referenced this pull request Jun 17, 2020
…lastic#1194)

* [DOCS] Fix problems found during doc testing

* Fix attribute resolution in example

* Mark all topics as licensed (xpack)

* Capitalize Agent to match current style guidelines

* Fix package registry and port

* Add limitations link to getting started

* Add experimental tag to all topics

* More changes to capitalize Agent

* Fix TIP formatting to include output

* A few more issues found during testing
dedemorton added a commit that referenced this pull request Jun 17, 2020
…1194) (#1195)

* [DOCS] Fix problems found during doc testing

* Fix attribute resolution in example

* Mark all topics as licensed (xpack)

* Capitalize Agent to match current style guidelines

* Fix package registry and port

* Add limitations link to getting started

* Add experimental tag to all topics

* More changes to capitalize Agent

* Fix TIP formatting to include output

* A few more issues found during testing
dedemorton added a commit that referenced this pull request Jun 17, 2020
…1194) (#1196)

* [DOCS] Fix problems found during doc testing

* Fix attribute resolution in example

* Mark all topics as licensed (xpack)

* Capitalize Agent to match current style guidelines

* Fix package registry and port

* Add limitations link to getting started

* Add experimental tag to all topics

* More changes to capitalize Agent

* Fix TIP formatting to include output

* A few more issues found during testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants