-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Fix problems in ingest management docs found during testing #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 tasks
bmorelli25
approved these changes
Jun 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ph
approved these changes
Jun 17, 2020
dedemorton
added a commit
to dedemorton/stack-docs
that referenced
this pull request
Jun 17, 2020
…lastic#1194) * [DOCS] Fix problems found during doc testing * Fix attribute resolution in example * Mark all topics as licensed (xpack) * Capitalize Agent to match current style guidelines * Fix package registry and port * Add limitations link to getting started * Add experimental tag to all topics * More changes to capitalize Agent * Fix TIP formatting to include output * A few more issues found during testing
dedemorton
added a commit
to dedemorton/stack-docs
that referenced
this pull request
Jun 17, 2020
…lastic#1194) * [DOCS] Fix problems found during doc testing * Fix attribute resolution in example * Mark all topics as licensed (xpack) * Capitalize Agent to match current style guidelines * Fix package registry and port * Add limitations link to getting started * Add experimental tag to all topics * More changes to capitalize Agent * Fix TIP formatting to include output * A few more issues found during testing
dedemorton
added a commit
that referenced
this pull request
Jun 17, 2020
…1194) (#1195) * [DOCS] Fix problems found during doc testing * Fix attribute resolution in example * Mark all topics as licensed (xpack) * Capitalize Agent to match current style guidelines * Fix package registry and port * Add limitations link to getting started * Add experimental tag to all topics * More changes to capitalize Agent * Fix TIP formatting to include output * A few more issues found during testing
dedemorton
added a commit
that referenced
this pull request
Jun 17, 2020
…1194) (#1196) * [DOCS] Fix problems found during doc testing * Fix attribute resolution in example * Mark all topics as licensed (xpack) * Capitalize Agent to match current style guidelines * Fix package registry and port * Add limitations link to getting started * Add experimental tag to all topics * More changes to capitalize Agent * Fix TIP formatting to include output * A few more issues found during testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues identified by @bmorelli25 during doc testing.
This PR has a dependency on elastic/beats#19252. CI will fail until the beats PR is merged.
You won't be able to see an HTML preview until after the agent PR is merged