Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.6] Changes 'in-progress' to 'acknowledged' #2811

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Conversation

benironside
Copy link
Contributor

@benironside benironside commented Jan 5, 2023

Fixes #2798. Small bugfix.

Preview

@benironside benironside requested a review from a team January 5, 2023 17:08
@benironside benironside self-assigned this Jan 5, 2023
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Documentation previews:

@benironside benironside marked this pull request as ready for review January 5, 2023 17:21
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny Oxford comma edit...

Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for @joepeeples comment -- other than that LGTM!

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
@benironside benironside merged commit 2aaa334 into main Jan 5, 2023
mergify bot pushed a commit that referenced this pull request Jan 5, 2023
* Changes 'in-progress' to 'acknowledged'

* Update docs/detections/api/rules/signals-api-overview.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit 2aaa334)
benironside added a commit that referenced this pull request Jan 5, 2023
* Changes 'in-progress' to 'acknowledged'

* Update docs/detections/api/rules/signals-api-overview.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit 2aaa334)

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
@benironside benironside deleted the issue-2798-big branch January 5, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] "Set alert status" API doc mentions "in-progress" status instead of "acknowledged"
3 participants