Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Update case priv docs #1443

Merged
merged 12 commits into from
Feb 8, 2022
Merged

[DOCS] Update case priv docs #1443

merged 12 commits into from
Feb 8, 2022

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Jan 25, 2022 •
edited
Loading

Addresses #1403.

Preview here.

@nastasha-solomon nastasha-solomon self-assigned this Jan 25, 2022
@nastasha-solomon nastasha-solomon changed the title First draft. [DOCS] Update case priv docs Jan 25, 2022
@nastasha-solomon nastasha-solomon marked this pull request as ready for review January 27, 2022 18:19
joepeeples
joepeeples reviewed Jan 27, 2022
View reviewed changes
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments, otherwise LGTM!

@nastasha-solomon nastasha-solomon linked an issue Jan 30, 2022 that may be closed by this pull request
[DOCS] Update case priv docs #1403
Closed
jmikell821
jmikell821 approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree w/ previous feedback left. Looks good otherwise!

jmikell821
jmikell821 reviewed Jan 31, 2022
View reviewed changes
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small attribute nit, otherwise LGTM.

XavierM
XavierM approved these changes Feb 7, 2022
View reviewed changes
Copy link

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM because @nastasha-solomon told me that

we group our recommendations for case and connector privs together because both are required to have full access to managing cases.

@nastasha-solomon nastasha-solomon merged commit f82195e into main Feb 8, 2022
@nastasha-solomon nastasha-solomon deleted the issue-1403-case-privs branch February 8, 2022 22:15
mergify bot pushed a commit that referenced this pull request Feb 8, 2022
@nastasha-solomon
[DOCS] Update case priv docs (#1443)
17fa245 
(cherry picked from commit f82195e)
@mergify mergify bot mentioned this pull request Feb 8, 2022
Merged
mergify bot pushed a commit that referenced this pull request Feb 8, 2022
@nastasha-solomon
[DOCS] Update case priv docs (#1443)
60219e9 
(cherry picked from commit f82195e)
@mergify mergify bot mentioned this pull request Feb 8, 2022
Merged
nastasha-solomon added a commit that referenced this pull request Feb 8, 2022
@mergify @nastasha-solomon
[8.1] [DOCS] Update case priv docs (backport #1443) (#1528)
12435ba 
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
nastasha-solomon added a commit that referenced this pull request Feb 8, 2022
@mergify @nastasha-solomon
[8.0] [DOCS] Update case priv docs (backport #1443) (#1529)
b8ce69e 
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikell821 jmikell821 jmikell821 approved these changes

@joepeeples joepeeples joepeeples left review comments

@benironside benironside benironside left review comments

@XavierM XavierM XavierM approved these changes

Assignees

@nastasha-solomon nastasha-solomon

Labels
Team: Docs Team: Threat Hunting Formerly Data Visibility v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS] Update case priv docs
5 participants
@nastasha-solomon @XavierM @jmikell821 @joepeeples @benironside