Add searches on multiple segments for dense vector #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With introduction of concurrent search across multiple segments elastic/elasticsearch#98204 there is a need to measure search across multiple segments before force merge. This PR adds this operation.
|
Results from my M1 Mac laptop
Full results: |
jimczi
reviewed
Sep 5, 2023
There was a problem hiding this comment.
Thanks Mayya.
A few comments:
- Should we also run the ann recall with multiple segments ?
- Why not running knn-search-10-100 (in addition to 100-1000)?
We should also add a test for the multi-threaded search.
We can (de)activate the setting with:
{
"name": "disable_search_worker_thread",
"tags": ["setup"],
"operation": {
"operation-type": "raw-request",
"method": "PUT",
"path": "/_cluster/settings",
"body": {
"transient": {
"search.worker_threads_enabled" : false
}
},
"include-in-reporting": false
}
}
Can be a follow up though so feel free to ignore if you prefer to keep this PR smaller.
|
Is it still necessary to test without concurrency? The |
I think we're passed that but I thought that it would be nice to expose this in our benchmarks. I am fine if we don't though since we'll still be able to find regression. |
|
Sorry for the late follow-up, this completely slipped my radar. @jimczi I've addressed you comments in 0a53e3a, adding Results from the latest run: |
inqueue
pushed a commit
to inqueue/rally-tracks
that referenced
this pull request
Dec 6, 2023
With introduction of concurrent search across multiple segments elastic/elasticsearch#98204 there is a need to measure search across multiple segments before force merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With introduction of concurrent search across multiple segments elastic/elasticsearch/pull/98204 there is a need to measure search across multiple segments before force merge.
This PR adds this operation.