Report warnings as errors by default #636
Conversation
There was a problem hiding this comment.
I like the idea to change these warnings to be errors that could be filtered.
But it will also require to add in most of the packages defined in the integrations repository the validation.yml file including these new codes. And probably (endpoint, apm...). I guess this is affordable.
|
/test |
💚 Build Succeeded
History
cc @jsoriano |
| {fn: semantic.WarnOn(semantic.ValidateMinimumKibanaVersion), until: semver.MustParse("3.0.0")}, | ||
| {fn: semantic.ValidateMinimumKibanaVersion, since: semver.MustParse("3.0.0")}, |
There was a problem hiding this comment.
Ah! So until 3.0.0 is the same behaviour, that's perfect!
I didn't remember that until parameter 👍
| @@ -9,10 +9,13 @@ const ( | |||
| UnassignedCode = "" | |||
|
|
|||
| // PSR - Package Spec [General] Rule | |||
| CodeNonGASpecOnGAPackage = "PSR00001" | |||
| CodeNonGASpecOnGAPackage = "PSR00001" | |||
There was a problem hiding this comment.
I'd say this code can be removed, it looks like is not used right now
There was a problem hiding this comment.
It is used in
There was a problem hiding this comment.
Ah it's from other file out of this PR , sorry. I thought it was a new error code 👍
| @@ -9,10 +9,13 @@ const ( | |||
| UnassignedCode = "" | |||
|
|
|||
| // PSR - Package Spec [General] Rule | |||
| CodeNonGASpecOnGAPackage = "PSR00001" | |||
| CodeNonGASpecOnGAPackage = "PSR00001" | |||
There was a problem hiding this comment.
Ah it's from other file out of this PR , sorry. I thought it was a new error code 👍
What does this PR do?
Warnings that could be optionally enabled as errors are reported as errors now, and can be filtered-out. Starting on Package Spec v3.
Why is it important?
To raise awareness on the issues reported by these warnings, so they are not so easily ignored, but can still be discarded.
Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.Related issues