Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: don't list old packages with categories incompatible with latest revisions #719

Merged
merged 3 commits into from
Sep 9, 2021

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Sep 9, 2021

Issue: #714

This PR addresses this and this issue, so that old packages are hidden from search results.

In tests:

example-0.0.2 has web category, but it's hidden from /search?category=web, because example-1.0.0 doesn't have this category. The implementation without all=true will focus only on latest packages. This is inline with numbers returned by category endpoint.

Personal comment:

I think that this search/category logic must be refactored as it's too much tangled at the moment.

@mtojek mtojek changed the title Fix 714 Fix: don't list old packages with categories incompatible with latest revisions Sep 9, 2021
@mtojek mtojek self-assigned this Sep 9, 2021
@elasticmachine
Copy link

elasticmachine commented Sep 9, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-09T12:26:57.193+0000

  • Duration: 4 min 24 sec

  • Commit: 4bffa2c

Test stats 🧪

Test Results
Failed 0
Passed 95
Skipped 0
Total 95

Trends 🧪

Image of Build Times

Image of Tests

@jsoriano
Copy link
Member

jsoriano commented Sep 9, 2021

I think that this search/category logic must be refactored as it's too much tangled at the moment.

+1, I should continue with #703 😅 where the search code is refactored an unified so all endpoints use the same.

@mtojek mtojek merged commit 9bc1a15 into elastic:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants