Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building and pushing multi-platform registry image #1162

Conversation

pkoutsovasilis
Copy link
Contributor

This PR builds package-registry container image as a multi-platform one, supporting linux/amd64 and linux/arm64, by utilising docker buildx. Having such an image of package-registry will help us achieve native execution of elastic-package stack up on arm64-based machines.

PS: I am not that experienced in buildkite to make sure that buildx is always installed and available on the runner 🙂

@mrodm mrodm requested a review from a team March 13, 2024 16:57
Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pkoutsovasilis !

It'd be great to have this support in the docker images generated 💪 Added some suggestions and doubts .

Pinging @jsoriano to take another look on this change, in case there is something missing from my side.

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add a changelog entry to CHANGELOG.md mentioning the new supported architectures.

I would sligthly prefer to keep the explicit retries, just in case.

I would also like to consider at some point the use of goreleaser, it also seems to support multi-platform docker images https://goreleaser.com/cookbooks/multi-platform-docker-images/
But to migrate to goreleaser we would also need to review how we generate the changelogs, so let's keep this for a separate change.

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pkoutsovasilis pkoutsovasilis merged commit 889bb35 into elastic:main Mar 26, 2024
3 checks passed
@pkoutsovasilis pkoutsovasilis deleted the pkoutsovasilis/registry_multiplatform_image branch March 26, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants