-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building and pushing multi-platform registry image #1162
Support building and pushing multi-platform registry image #1162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pkoutsovasilis !
It'd be great to have this support in the docker images generated 💪 Added some suggestions and doubts .
Pinging @jsoriano to take another look on this change, in case there is something missing from my side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please add a changelog entry to CHANGELOG.md mentioning the new supported architectures.
I would sligthly prefer to keep the explicit retries, just in case.
I would also like to consider at some point the use of goreleaser, it also seems to support multi-platform docker images https://goreleaser.com/cookbooks/multi-platform-docker-images/
But to migrate to goreleaser we would also need to review how we generate the changelogs, so let's keep this for a separate change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
💚 Build Succeeded
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR builds
package-registry
container image as a multi-platform one, supporting linux/amd64 and linux/arm64, by utilisingdocker buildx
. Having such an image of package-registry will help us achieve native execution ofelastic-package stack up
on arm64-based machines.PS: I am not that experienced in
buildkite
to make sure thatbuildx
is always installed and available on the runner 🙂